-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent deletion of snapshots that are mounted and ILM delete action #73947
Labels
:Data Management/ILM+SLM
Index and Snapshot lifecycle management
:Distributed/Snapshot/Restore
Anything directly related to the `_snapshot/*` APIs
>enhancement
Team:Data Management
Meta label for data/management team
Team:Distributed
Meta label for distributed team
Comments
tlrx
added
>enhancement
discuss
:Distributed/Snapshot/Restore
Anything directly related to the `_snapshot/*` APIs
:Data Management/ILM+SLM
Index and Snapshot lifecycle management
labels
Jun 9, 2021
elasticmachine
added
Team:Distributed
Meta label for distributed team
Team:Data Management
Meta label for data/management team
labels
Jun 9, 2021
Pinging @elastic/es-distributed (Team:Distributed) |
Pinging @elastic/es-core-features (Team:Core/Features) |
@henningandersen suggested the idea to add a flag to the existing Mount API to indicate that the index "owns" the snapshot and that it should be deleted when the searchable snapshot index is deleted. I'm going to give it try. |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this issue
May 9, 2024
The word `cannot` implies Elasticsearch prevents you from doing these things, but it doesn't have this protection today (see elastic#73947). This commit clarifies this by saying `must not` instead. Closes elastic#108450
DaveCTurner
added a commit
that referenced
this issue
May 9, 2024
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this issue
May 9, 2024
The word `cannot` implies Elasticsearch prevents you from doing these things, but it doesn't have this protection today (see elastic#73947). This commit clarifies this by saying `must not` instead. Closes elastic#108450
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this issue
May 9, 2024
The word `cannot` implies Elasticsearch prevents you from doing these things, but it doesn't have this protection today (see elastic#73947). This commit clarifies this by saying `must not` instead. Closes elastic#108450
elasticsearchmachine
pushed a commit
that referenced
this issue
May 9, 2024
elasticsearchmachine
pushed a commit
that referenced
this issue
May 9, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Data Management/ILM+SLM
Index and Snapshot lifecycle management
:Distributed/Snapshot/Restore
Anything directly related to the `_snapshot/*` APIs
>enhancement
Team:Data Management
Meta label for data/management team
Team:Distributed
Meta label for distributed team
Today nothing prevents the deletion of a snapshot that is used by a searchable snapshot index. If such a snapshot is deleted the mounted index will go RED in the future. We started to implement a check in #73821 to prevent the deletion of snapshots that are used by searchable snapshots indices within the same cluster and it made some ILM tests to fail.
ILM has a delete index action
DeleteAction
with adelete_searchable_snapshot
flag that, when set totrue
(the default value), deletes the snapshot that is mounted before deleting the index. ILM deletes the snapshot before the index because the information about the snapshot are stored in the index's metadata (under the ILM custom metedata). If ILM was deleting the searchable snapshot index before the snapshot it would not know which snapshot to delete.I still think it is important to prevent the deletion of mounted snapshots so we should investigate how to keep the ILM behavior while implementing a safety check in #73821.
I can see different solution and I'm opening this issue to discuss them:
The text was updated successfully, but these errors were encountered: