-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encapsulate native access #104876
Closed
Closed
Encapsulate native access #104876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also cleaned up unused jna code from server.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Mar 9, 2024
This commit moves systemd access to the NativeAccess lib. relates elastic#104876
rjernst
added a commit
that referenced
this pull request
Mar 12, 2024
This commit moves systemd access to the NativeAccess lib. relates #104876
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
May 18, 2024
This commit moves getting max threads, max virtual memory size, and max file size into NativeAccess. relates elastic#104876
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 20, 2024
This commit moves getting max threads, max virtual memory size, and max file size into NativeAccess. relates #104876
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
May 20, 2024
This commit moves the implementations of locking virtual memory into RAM into NativeAccess. relates elastic#104876
rjernst
added a commit
that referenced
this pull request
May 21, 2024
This commit moves the implementations of locking virtual memory into RAM into NativeAccess. relates #104876
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
May 21, 2024
Elasticsearch uses a couple windows specific functions, specifically gettting a short path, and registering a console control handler for shutdown notification. This commit moves this functionality from the existing jna natives into NativeAccess. relates elastic#104876
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 23, 2024
Elasticsearch uses a couple windows specific functions, specifically gettting a short path, and registering a console control handler for shutdown notification. This commit moves this functionality from the existing jna natives into NativeAccess. relates #104876
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
May 23, 2024
This commit moves the system call filtering initialization into NativeAccess. The code is essentially unmodified from its existing state, now existing within the *NativeAccess implementations. relates elastic#104876
rjernst
added a commit
that referenced
this pull request
Jul 9, 2024
This commit moves the system call filtering initialization into NativeAccess. The code is essentially unmodified from its existing state, now existing within the *NativeAccess implementations. relates #104876
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Jul 9, 2024
This commit moves the file preallocation functionality into NativeAccess. The code is basically the same. One small tweak is that instead of breaking Java access boundaries in order to get an open file handle, the new code uses posix open directly. relates elastic#104876
rjernst
added a commit
that referenced
this pull request
Jul 11, 2024
This commit moves the file preallocation functionality into NativeAccess. The code is basically the same. One small tweak is that instead of breaking Java access boundaries in order to get an open file handle, the new code uses posix open directly. relates #104876
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Jul 11, 2024
All native methods are now bound through NativeAccess. This commit removes the jna dependency from server. relates elastic#104876
rjernst
added a commit
that referenced
this pull request
Jul 13, 2024
All native methods are now bound through NativeAccess. This commit removes the jna dependency from server. relates #104876
This PR has been merged through the linked PRs, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP branch which moves JNA into a new internal lib, elasticsearch-native. It also hides JNA inside an implementation of a new NativeAccess api. Finally, it implements the NativeAccess api with Java's Foreign Function Interface when java 21+ is present.