Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Health API more resilient to multi-version clusters #105789

Merged
merged 7 commits into from
Mar 4, 2024
Merged

Make Health API more resilient to multi-version clusters #105789

merged 7 commits into from
Mar 4, 2024

Conversation

nielsbauman
Copy link
Contributor

First check whether the full cluster supports a specific indicator (feature) before we mark an indicator as "unknown" when (meta) data is missing form the cluster state.

Closes #90183

@nielsbauman
Copy link
Contributor Author

Is this something we want to backport?

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine
Copy link
Collaborator

Hi @nielsbauman, I've created a changelog YAML for you.

dakrone
dakrone approved these changes Mar 2, 2024
View reviewed changes
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left a couple of minor wording suggestions.

Is this something we want to backport?

Yes, I think so, we hit this in tests and its a real issue for mixed-version clusters. I think backporting it to 8.13.x would be good.

server/src/main/java/org/elasticsearch/health/node/DiskHealthIndicatorService.java Outdated Show resolved Hide resolved
server/src/main/java/org/elasticsearch/health/node/ShardsCapacityHealthIndicatorService.java Outdated Show resolved Hide resolved
@nielsbauman nielsbauman requested a review from dakrone March 4, 2024 10:12
@nielsbauman nielsbauman added v8.13.1 auto-backport Automatically create backport pull requests when merged labels Mar 4, 2024
@nielsbauman nielsbauman merged commit 9c1a079 into elastic:main Mar 4, 2024
14 checks passed
@nielsbauman nielsbauman deleted the health-api-bwc branch March 4, 2024 12:59
@nielsbauman nielsbauman mentioned this pull request Mar 4, 2024
Merged
nielsbauman added a commit to nielsbauman/elasticsearch that referenced this pull request Mar 4, 2024
@nielsbauman
Make Health API more resilient to multi-version clusters (elastic#105789
7529dc9 
)

First check whether the full cluster supports a specific indicator (feature) before we mark an indicator as "unknown" when (meta) data is missing from the cluster state.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.13

elasticsearchmachine pushed a commit that referenced this pull request Mar 4, 2024
@nielsbauman
Make Health API more resilient to multi-version clusters (#105789) (#…
111b221 
…105903)

First check whether the full cluster supports a specific indicator (feature) before we mark an indicator as "unknown" when (meta) data is missing from the cluster state.
@benwtrent benwtrent mentioned this pull request Mar 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakrone dakrone Awaiting requested review from dakrone

Assignees
No one assigned
Labels
auto-backport Automatically create backport pull requests when merged >bug :Data Management/Health Team:Data Management Meta label for data/management team v8.13.1 v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] MixedClusterClientYamlTestSuiteIT test {p0=health/10_basic/cluster health basic test} failing
3 participants
@nielsbauman @elasticsearchmachine @dakrone