Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race in SpawnerNoBootstrapTests #108416

Merged
merged 3 commits into from
May 9, 2024
Merged

Conversation

thecoop
Copy link
Member

@thecoop thecoop commented May 8, 2024

Fix #108239. The count down is hit on any log output, not just the matching one, so there's a chance the countdown could complete before the correct log message is actually output. Previously this test was failing after ~100 iterations, with this change it passes over 1000 times in a row

@thecoop thecoop added >test Issues or PRs that are addressing/adding tests :Core/Infra/Core Core issues without another label labels May 8, 2024
@thecoop thecoop requested a review from a team May 8, 2024 14:48
@elasticsearchmachine elasticsearchmachine added v8.15.0 Team:Core/Infra Meta label for core/infra team labels May 8, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one suggestion

@thecoop thecoop merged commit f5b356d into elastic:main May 9, 2024
15 checks passed
@thecoop thecoop deleted the spawner-test-race branch May 9, 2024 09:16
markjhoy pushed a commit to markjhoy/elasticsearch that referenced this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] SpawnerNoBootstrapTests testControllerSpawn failing
3 participants