Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Fix stored_fields parameter description #108445

Merged
merged 1 commit into from
May 9, 2024
Merged

[DOCS] Fix stored_fields parameter description #108445

merged 1 commit into from
May 9, 2024

Conversation

nicktindall
Copy link
Contributor

(referenced from get and multi_get API docs)

Closes #98385

@nicktindall nicktindall requested a review from ywangd May 9, 2024 06:20
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2024

Documentation preview:

@nicktindall nicktindall requested a review from repantis May 9, 2024 06:20
@nicktindall nicktindall added the >docs General docs changes label May 9, 2024
@elasticsearchmachine elasticsearchmachine added v8.15.0 needs:triage Requires assignment of a team area label Team:Docs Meta label for docs team labels May 9, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label May 9, 2024
@nicktindall nicktindall force-pushed the fix/98385_fix_stored_fields_parameter_docs branch from 8b0a1f0 to a80dc76 Compare May 9, 2024 06:26
@nicktindall nicktindall added the Team:Distributed Meta label for distributed team label May 9, 2024
@elasticsearchmachine elasticsearchmachine removed the Team:Distributed Meta label for distributed team label May 9, 2024
@nicktindall nicktindall added the :Distributed/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. label May 9, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Meta label for distributed team label May 9, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@nicktindall nicktindall added v7.17.22 and removed Team:Distributed Meta label for distributed team labels May 9, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Meta label for distributed team label May 9, 2024
@nicktindall nicktindall added v8.14.0 and removed Team:Distributed Meta label for distributed team labels May 9, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Meta label for distributed team label May 9, 2024
@nicktindall nicktindall removed the request for review from repantis May 9, 2024 06:51
@nicktindall
[DOCS] Fix stored_fields parameter description (elastic#98385)
f9800c9 
(referenced from get and multi_get API docs)

Closes elastic#98385
@nicktindall nicktindall force-pushed the fix/98385_fix_stored_fields_parameter_docs branch from a80dc76 to f9800c9 Compare May 9, 2024 06:54
ywangd
ywangd approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@ywangd ywangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/reference/rest-api/common-parms.asciidoc Outdated Show resolved Hide resolved
@nicktindall nicktindall added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label May 9, 2024
@nicktindall nicktindall changed the title [DOCS] Fix stored_fields parameter description (#98385) [DOCS] Fix stored_fields parameter description May 9, 2024
@elasticsearchmachine elasticsearchmachine merged commit 68a8664 into elastic:main May 9, 2024
5 checks passed
@nicktindall nicktindall mentioned this pull request May 9, 2024
Merged
nicktindall added a commit to nicktindall/elasticsearch that referenced this pull request May 9, 2024
@nicktindall
[DOCS] Fix stored_fields parameter description (elastic#98385) (elast…
8487dc7 
…ic#108445)

(referenced from get and multi_get API docs)

Closes elastic#98385
@nicktindall nicktindall mentioned this pull request May 9, 2024
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.14
✅ 7.17

@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

The backport operation could not be completed due to the following error:

There are no branches to backport to. Aborting.

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 108445

elasticsearchmachine pushed a commit that referenced this pull request May 9, 2024
@nicktindall
[DOCS] Fix stored_fields parameter description (#98385) (#108445) (#1…
f6ac110 
…08446)

(referenced from get and multi_get API docs)

Closes #98385
elasticsearchmachine pushed a commit that referenced this pull request May 9, 2024
@nicktindall
[DOCS] Fix stored_fields parameter description (#98385) (#108445) (#1…
2a327b1 
…08447)

(referenced from get and multi_get API docs)

Closes #98385
markjhoy pushed a commit to markjhoy/elasticsearch that referenced this pull request May 9, 2024
@nicktindall @markjhoy
[DOCS] Fix stored_fields parameter description (elastic#98385) (elast…
be4615e 
…ic#108445)

(referenced from get and multi_get API docs)

Closes elastic#98385
@nicktindall nicktindall deleted the fix/98385_fix_stored_fields_parameter_docs branch May 17, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywangd ywangd ywangd approved these changes

Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >docs General docs changes Team:Distributed Meta label for distributed team Team:Docs Meta label for docs team v7.17.22 v8.14.0 v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get API has wrong description for stored_fields parameter
3 participants
@nicktindall @elasticsearchmachine @ywangd