Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version-guard checking for lossy params in _source #108460

Merged
merged 1 commit into from
May 9, 2024

Conversation

kkrik-es
Copy link
Contributor

@kkrik-es kkrik-es commented May 9, 2024

This prevents applying the check to older indexes. If they violated it, there would be no way to access them and update their mappings, leading to data loss and red clusters.

@kkrik-es kkrik-es added >non-issue Team:StorageEngine :StorageEngine/Mapping The storage related side of mappings labels May 9, 2024
@kkrik-es kkrik-es self-assigned this May 9, 2024
@kkrik-es kkrik-es requested a review from dnhatn May 9, 2024 14:17
@kkrik-es kkrik-es marked this pull request as ready for review May 9, 2024 14:29
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @kkrik-es.

@kkrik-es kkrik-es merged commit 4dcbc3b into elastic:main May 9, 2024
15 checks passed
markjhoy pushed a commit to markjhoy/elasticsearch that referenced this pull request May 9, 2024
@kkrik-es kkrik-es deleted the source-lossy-params/version branch May 10, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants