[Transform] Forward indexServiceSafe exceptions to listener #108517
Merged
+85
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IndexService.indexServiceSafe can throw an IndexNotFoundException while getting the Global Checkpoints. TransportGetCheckpointNodeAction will now forward that exception to the listener. Fix elastic#108418
prwhelan
added
>bug
:ml/Transform
|
Hi @prwhelan, I've created a changelog YAML for you. |
|
Pinging @elastic/ml-core (Team:ML) |
przemekwitek
approved these changes
May 13, 2024
| }); | ||
| checkpointsByIndexOfThisNode.get(shardId.getIndexName())[shardId.getId()] = indexShard.seqNoStats().getGlobalCheckpoint(); | ||
| ++numProcessedShards; | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
The PR description says that the IndexNotFoundException is forwarded but in fact every exception is forwarded here.
I think the code is ok, just please update PR description.
prwhelan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IndexService.indexServiceSafe can throw an IndexNotFoundException while getting the Global Checkpoints.
In theory, any exception in TransportGetCheckpointNodeAction should be forwarded to the listener.
Fix #108418