Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding override for lintian false positive on libvec.so #108521

Merged
merged 4 commits into from
May 13, 2024

Conversation

ldematte
Copy link
Contributor

@ldematte ldematte commented May 10, 2024

Executing lintian on our deb distribution after #108088 was merged raises the following warning (treated as error): shared-lib-without-dependency-information

From the lintian docs:

The listed shared library doesn't include information about the
other libraries against which it was linked.
More specifically, "ldd foo.so" should report such other
libraries. In your case, it reports "statically linked".
The fix is to specify the libraries. One way to do so is to add
something like "-lc" to the command-line options for "ld".

It's true that ldd libvec.so does report "statically linked", but that's correct in our case: we do not reference any external symbol, not event from the standard C library. Googling around, this is commonly treated as a false positive in similar cases, so I'm adding an override for this rule for the libvec.so

Closes #108514

@ldematte ldematte added >bug :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts :Search/Search Search-related issues that do not fall into other categories labels May 10, 2024
@ldematte ldematte requested a review from mark-vieira May 10, 2024 19:00
@ldematte ldematte requested a review from a team as a code owner May 10, 2024 19:00
@elasticsearchmachine elasticsearchmachine added Team:Search Meta label for search team Team:Delivery Meta label for Delivery team v8.15.0 labels May 10, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@elasticsearchmachine
Copy link
Collaborator

Hi @ldematte, I've created a changelog YAML for you.

@ldematte
Copy link
Contributor Author

@elasticmachine update branch

@ldematte ldematte merged commit 89d666b into elastic:main May 13, 2024
18 checks passed
@ldematte ldematte deleted the native-vec-lintian branch May 13, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts :Search/Search Search-related issues that do not fall into other categories Team:Delivery Meta label for Delivery team Team:Search Meta label for search team v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] DebMetadataTests test05CheckLintian failing
4 participants