[ESQL] Mark date_diff as requiring all three arguments #108834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
|
Hi @not-napoleon, I've created a changelog YAML for you. |
…-diff-missing-arg' into esql-fix-date-diff-missing-arg
bpintea
approved these changes
May 21, 2024
|
Since this is a bug, please backport it to 8.14. |
💚 Backport successful
|
not-napoleon
added a commit
to not-napoleon/elasticsearch
that referenced
this pull request
May 21, 2024
Resolves elastic#108383 I didn't see a good place to add a test for this; if there is one, let me know and I'm happy to add it. This fixes a bug where we had incorrectly marked date_diff as having an optional argument, which resulted in an NPE when that argument was not provided. In fact, all three of date_diff's arguments are required. After this change, failing to provide one will cause a parse exception, as one would expect.
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 21, 2024
…8874) Resolves #108383 I didn't see a good place to add a test for this; if there is one, let me know and I'm happy to add it. This fixes a bug where we had incorrectly marked date_diff as having an optional argument, which resulted in an NPE when that argument was not provided. In fact, all three of date_diff's arguments are required. After this change, failing to provide one will cause a parse exception, as one would expect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #108383
I didn't see a good place to add a test for this; if there is one, let me know and I'm happy to add it.
This fixes a bug where we had incorrectly marked
date_diffas having an optional argument, which resulted in an NPE when that argument was not provided. In fact, all three ofdate_diff's arguments are required. After this change, failing to provide one will cause a parse exception, as one would expect.