ESQL: Stop sending version in tests #108961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that `version` is no longer required anywhere we can stop sending it in all of our tests. Closes elastic#108957
nik9000
added
>non-issue
test-full-bwc
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
luigidellaquila
approved these changes
May 23, 2024
mark-vieira
approved these changes
May 23, 2024
|
Failures seem to be related to #108976 which I think we were masking. I'm going to merge if the last bwc looks good. |
💔 Backport failed
You can use sqren/backport to manually backport by running |
Fine. I'll do it with my fingers. |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
May 23, 2024
Now that `version` is no longer required anywhere we can stop sending it in all of our tests. Closes elastic#108957
|
Backport: #108984 |
alex-spies
pushed a commit
that referenced
this pull request
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
versionis no longer required anywhere we can stop sending it in all of our tests.Closes #108957