Make ip fields backward-compatible at query time. #18593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
| } | ||
|
|
||
| public final void clear() { | ||
| // can't do |
There was a problem hiding this comment.
By this comment do we mean "there is nothing to do here" or "this should never be called"? If it's the latter should we throw an UnsupportedOperationException instead? If it's the former could we instead change the comment to // nothing to do?
There was a problem hiding this comment.
It is the former. I will fix the comment.
|
@jpountz I left a couple of comments |
|
@colings86 I fixed the comments. |
|
@jpountz thanks, LGTM |
The fact that ip fields used a different doc values representation in 2.x causes issues when querying 2.x and 5.0 indices in the same request. This changes 2.x doc values on ip fields/2.x to be hidden behind binary doc values that use the same encoding as 5.0. This way the coordinating node will be able to merge shard responses that have different major versions. One known issue is that this makes sorting/aggregating slower on ip fields for indices that have been generated with elasticsearch 2.x.
jpountz
force-pushed
the
fix/ip_back_compat
branch
from
39adb9c
to
adf4712
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fact that ip fields used a different doc values representation in 2.x causes
issues when querying 2.x and 5.0 indices in the same request. This changes 2.x
doc values on ip fields/2.x to be hidden behind binary doc values that use the
same encoding as 5.0. This way the coordinating node will be able to merge shard
responses that have different major versions.
One known issue is that this makes sorting/aggregating slower on ip fields for
indices that have been generated with elasticsearch 2.x.
Relates to #17971