Squash the rest of o.e.rest.action #19698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this is a net loss of about 10 packages. Mostly consolidating tiny packages into medium sized packages. |
|
Also package descriptions to all the packages in |
|
Marking it breaking-java because it moves some utility classes for handling REST. Plugins will have to change the import locations if they use them |
|
LGTM |
Squashes all the subpackages of `org.elasticsearch.rest.action` down to the following: * `o.e.rest.action.admin` - Administrative actions * `o.e.rest.action.cat` - Actions that make tables for `grep`ing * `o.e.rest.action.document` - Actions that act on documents * `o.e.rest.action.ingest` - Actions that act on ingest pipelines * `o.e.rest.action.search` - Actions that search I'm tempted to merge `search` into `document` but the `document` package feels fairly complete as is and `Suggest` isn't actually always about documents either.... I'm also tempted to merge `ingest` into `admin.cluster` because the latter contains the actions for dealing with stored scripts. I've moved the `o.e.rest.action.support` into `o.e.rest.action`. I've also added `package-info.java`s to all packges in `o.e.rest`. I figure if the package is too small to deserve a `package-info.java` file then it is too small to deserve to be a package.... Also fixes checkstyle in all moved classes.
nik9000
force-pushed
the
package_info_4
branch
from
2a5f2aa
to
1452ab4
Compare
|
Thanks for reviewing @cbuescher ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squashes all the subpackages of
org.elasticsearch.rest.actiondown tothe following:
o.e.rest.action.admin- Administrative actionso.e.rest.action.cat- Actions that make tables forgrepingo.e.rest.action.document- Actions that act on documentso.e.rest.action.ingest- Actions that act on ingest pipelineso.e.rest.action.search- Actions that searchI'm tempted to merge
searchintodocumentbut thedocumentpackage feels fairly complete as is and
Suggestisn't actually alwaysabout documents either....
I'm also tempted to merge
ingestintoadmin.clusterbecause thelatter contains the actions for dealing with stored scripts.
I've moved the
o.e.rest.action.supportintoo.e.rest.action.