Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VersionFetchSubPhase should not use Versions#loadDocIdAndVersion #19944

Merged
merged 1 commit into from
Aug 11, 2016
Merged

VersionFetchSubPhase should not use Versions#loadDocIdAndVersion #19944

merged 1 commit into from
Aug 11, 2016

Conversation

jimczi
Copy link
Contributor

@jimczi jimczi commented Aug 11, 2016

Since we already know the docId, the PK lookup is useless and we can directly get the value from the numeric doc values.

@jimczi
VersionFetchSubPhase should not use Versions#loadDocIdAndVersion
1f75d05 
Since we already know the docId, the PK lookup is useless and we can directly get the value from the numeric doc values.
@jpountz
Copy link
Contributor

jpountz commented Aug 11, 2016

LGTM. IndicesTTLService should do the same.

@jimczi jimczi mentioned this pull request Aug 11, 2016
Merged
@jimczi
Copy link
Contributor Author

jimczi commented Aug 11, 2016

Thanks @jpountz ! I'll merge if the elasticsearch-ci succeeds.

IndicesTTLService should do the same.

Good catch, I checked for loadDocIdAndVersion only. I opened #19945 as a follow up.

@jimczi jimczi merged commit e8be32e into elastic:master Aug 11, 2016
@jimczi jimczi deleted the version_lookup branch August 11, 2016 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
>enhancement v5.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimczi @jpountz