Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VersionFetchSubPhase should not use Versions#loadDocIdAndVersion #19944

Merged
merged 1 commit into from Aug 11, 2016

Conversation

Projects
None yet
2 participants
@jimczi
Copy link
Member

commented Aug 11, 2016

Since we already know the docId, the PK lookup is useless and we can directly get the value from the numeric doc values.

VersionFetchSubPhase should not use Versions#loadDocIdAndVersion
Since we already know the docId, the PK lookup is useless and we can directly get the value from the numeric doc values.
@jpountz

This comment has been minimized.

Copy link
Contributor

commented Aug 11, 2016

LGTM. IndicesTTLService should do the same.

@jimczi

This comment has been minimized.

Copy link
Member Author

commented Aug 11, 2016

Thanks @jpountz ! I'll merge if the elasticsearch-ci succeeds.

IndicesTTLService should do the same.

Good catch, I checked for loadDocIdAndVersion only. I opened #19945 as a follow up.

@jimczi jimczi merged commit e8be32e into elastic:master Aug 11, 2016

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci Build finished.
Details

@jimczi jimczi deleted the jimczi:version_lookup branch Aug 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.