Do not parse numbers as both strings and numbers when not included in _all.
#20167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpountz
added
>enhancement
:Search Foundations/Mapping
|
LGTM |
jpountz
force-pushed
the
fix/text_and_double
branch
from
b86f740
to
c7fcf30
Compare
… `_all`. elastic#20167 We need to get the string representation of numbers in order to include in `_all`. However this has a cost and disabling `_all` is rather common so we should look into skipping it.
jpountz
force-pushed
the
fix/text_and_double
branch
from
c7fcf30
to
c5f8e1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to get the string representation of numbers in order to include in
_all. However this has a cost and disabling_allis rather common so weshould look into skipping it.