Change DiskThresholdDecider's behavior when factoring in leaving shards #20349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes DiskThresholdDecider to only factor in leaving shards when checking if a shard can remain. Previously, leaving shards were factored in for both the `canAllocate` and `canRemain` checks, however, this makes only the leaving shard sizes subtracted in the `canRemain` check. It was possible that multiple shards relocating away from the node would have their entire size subtracted, and the node had a chance to go over the disk threshold (or hit the disk full) because it subtracted space that was still being used for other in-progress relocations.
|
@dakrone this is great! LGTM |
|
Thanks for the quick review @abeyad! |
lcawl
added
:Distributed/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes DiskThresholdDecider to only factor in leaving shards when
checking if a shard can remain. Previously, leaving shards were factored
in for both the
canAllocateandcanRemainchecks, however, thismakes only the leaving shard sizes subtracted in the
canRemaincheck.It was possible that multiple shards relocating away from the node would
have their entire size subtracted, and the node had a chance to go over
the disk threshold (or hit the disk full) because it subtracted space
that was still being used for other in-progress relocations.