Deguice SearchService and friends #20423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes the guice dependency handling for SearchService and several releated classes liek SearchTransportController and SearchPhaseController. The latter two now have pkg private constructors and dependencies like FetchPhase are now created by calling their ctors explicitly. This also cleans up several users of the DefaultSearchContext and centralized it's creation inside SearchService.
| @@ -61,7 +61,6 @@ | |||
|
|
|||
| private VersionType versionType = VersionType.INTERNAL; | |||
| private long version = Versions.MATCH_ANY; | |||
| private boolean ignoreErrorsOnGeneratedFields; | |||
There was a problem hiding this comment.
Note to any other reviewers: this is no longer supported. I haven't dug too deep but my guess is that it was removed when we removed GET from the translog.
|
LGTM |
| @@ -795,8 +789,10 @@ BigArrays createBigArrays(Settings settings, CircuitBreakerService circuitBreake | |||
| /** | |||
| * Select the search service implementation. Overrided by tests. | |||
| */ | |||
| protected Class<? extends SearchService> pickSearchServiceImplementation() { | |||
| return SearchService.class; | |||
| protected SearchService newSearchService(ClusterService clusterService, IndicesService indicesService, | |||
There was a problem hiding this comment.
This is exactly what I had envisioned. Thank you!
|
Great! LGTM too. |
s1monw
added a commit
that referenced
this pull request
Sep 12, 2016
This change removes the guice dependency handling for SearchService and several related classes like SearchTransportController and SearchPhaseController. The latter two now have package private constructors and dependencies like FetchPhase are now created by calling their constructors explicitly. This also cleans up several users of the DefaultSearchContext and centralized it's creation inside SearchService.
s1monw
added a commit
that referenced
this pull request
Sep 12, 2016
This change removes the guice dependency handling for SearchService and several related classes like SearchTransportController and SearchPhaseController. The latter two now have package private constructors and dependencies like FetchPhase are now created by calling their constructors explicitly. This also cleans up several users of the DefaultSearchContext and centralized it's creation inside SearchService.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the guice dependency handling for SearchService and
several related classes like SearchTransportController and SearchPhaseController.
The latter two now have pkg private constructors and dependencies like FetchPhase
are now created by calling their ctors explicitly. This also cleans up several users
of the DefaultSearchContext and centralized it's creation inside SearchService.