Remove TransportService#registerRequestHandler leniency #20469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Maybe as a followup we could add a small test that verifies this behaviour when we register a handler twice? |
|
@javanna added a test |
`TransportService#registerRequestHandler` allowed to register handlers more than once and issues an annoying warn log message when this happens. This change simple throws an exception to prevent regsitering the same handler more than once. This commit also removes the ability to remove request handlers. Relates to elastic#20468
s1monw
force-pushed
the
remove_request_handler_leniency
branch
from
f7b5f95
to
e0c4c17
Compare
|
thanks @s1monw still LGTM |
| requestHandlers = MapBuilder.newMapBuilder(requestHandlers).put(reg.getAction(), reg).immutableMap(); | ||
| if (replaced != null) { | ||
| logger.warn("registered two transport handlers for action {}, handlers: {}, {}", reg.getAction(), reg, replaced); | ||
| if (requestHandlers.containsKey(reg.getAction())) { |
|
@bleskes I update the PR again removing the hack in MockTransportService |
|
LGTM |
|
retest this please |
s1monw
added a commit
that referenced
this pull request
Sep 14, 2016
`TransportService#registerRequestHandler` allowed to register handlers more than once and issues an annoying warn log message when this happens. This change simple throws an exception to prevent regsitering the same handler more than once. This commit also removes the ability to remove request handlers. Relates to #20468
s1monw
added a commit
that referenced
this pull request
Sep 14, 2016
`TransportService#registerRequestHandler` allowed to register handlers more than once and issues an annoying warn log message when this happens. This change simple throws an exception to prevent regsitering the same handler more than once. This commit also removes the ability to remove request handlers. Relates to #20468
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TransportService#registerRequestHandlerallowed to registerhandlers more than once and issues an annoying warn log message when
this happens. This change simple throws an exception to prevent registering
the same handler more than once. This commit also removes the ability
to remove request handlers.
Relates to #20468