Avoid unnecessary creation of prefix loggers #20571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today when acquiring a prefix logger for a logger info stream, we obtain a new prefix logger per invocation. This can lead to contention on the markers lock in the constructor of PrefixLogger. Usually this is not a problem (because the vast majority of callers hold on to the logger they obtain). Unfortunately, under heavy indexing with multiple threads, the contention on the lock can be devastating. This commit modifies LoggerInfoStream to hold on to the loggers it obtains to avoid contending over the lock there.
jasontedor
added
blocker
review
:Core/Infra/Logging
|
LGTM |
|
Thanks @mikemccand! |
jasontedor
added a commit
that referenced
this pull request
Sep 20, 2016
Today when acquiring a prefix logger for a logger info stream, we obtain a new prefix logger per invocation. This can lead to contention on the markers lock in the constructor of PrefixLogger. Usually this is not a problem (because the vast majority of callers hold on to the logger they obtain). Unfortunately, under heavy indexing with multiple threads, the contention on the lock can be devastating. This commit modifies LoggerInfoStream to hold on to the loggers it obtains to avoid contending over the lock there. Relates #20571
jasontedor
added a commit
that referenced
this pull request
Sep 20, 2016
Today when acquiring a prefix logger for a logger info stream, we obtain a new prefix logger per invocation. This can lead to contention on the markers lock in the constructor of PrefixLogger. Usually this is not a problem (because the vast majority of callers hold on to the logger they obtain). Unfortunately, under heavy indexing with multiple threads, the contention on the lock can be devastating. This commit modifies LoggerInfoStream to hold on to the loggers it obtains to avoid contending over the lock there. Relates #20571
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today when acquiring a prefix logger for a logger info stream, we obtain
a new prefix logger per invocation. This can lead to contention on the
markers lock in the constructor of PrefixLogger. Usually this is not a
problem (because the vast majority of callers hold on to the logger they
obtain). Unfortunately, under heavy indexing with multiple threads, the
contention on the lock can be devastating. This commit modifies
LoggerInfoStream to hold on to the loggers it obtains to avoid
contending over the lock there.
Closes #20570