Ensure logging is initialized in CLI tools #20575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today when CLI tools are executed, logging statements can intentionally or unintentionally be executed when logging is not configured. This leads to log messages that the status logger is not configured. This commit reworks logging configuration for CLI tools so that logging is always configured.
jasontedor
added
>enhancement
review
:Core/Infra/Logging
|
LGTM as well. Thanks @jasontedor for tracking this down |
This commit removes the ability to configure individual loggers in CLI tools; this is a feature that is probably not needed as setting the root logger level should be sufficient here.
|
Thanks for looking @abeyad and @jaymode. On second thought I decided to remove the ability to configure individual loggers for CLI tools, it's the root logger or nothing. I pushed 72d2e06; can you please take a look? (Note that that feature was never there before, I just added it in the first version of this PR.) |
|
Still LGTM |
This commit cleans up LogConfigurator: - removes unnecessary newlines in a method defintion - moves a comment to clarify its intent - adds a null check on two method parameters
jasontedor
added a commit
that referenced
this pull request
Sep 20, 2016
Today when CLI tools are executed, logging statements can intentionally or unintentionally be executed when logging is not configured. This leads to log messages that the status logger is not configured. This commit reworks logging configuration for CLI tools so that logging is always configured. Relates #20575
jasontedor
added a commit
that referenced
this pull request
Sep 20, 2016
Today when CLI tools are executed, logging statements can intentionally or unintentionally be executed when logging is not configured. This leads to log messages that the status logger is not configured. This commit reworks logging configuration for CLI tools so that logging is always configured. Relates #20575
This was referenced Aug 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today when CLI tools are executed, logging statements can intentionally
or unintentionally be executed when logging is not configured. This
leads to log messages that the status logger is not configured. This
commit reworks logging configuration for CLI tools so that logging is
always configured.