Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transport client: Fix remove address to actually work #21743

Merged
merged 2 commits into from
Nov 23, 2016

Commits on Nov 22, 2016

  1. Transport client: Fix remove address to actually work

    The removeTransportAddress method of TransportClient removes the address
    from the list of nodes that the client pings to sniff for nodes.
    However, it does not remove it from the list of existing connected
    nodes. This means removing a node is not possible, as long as that node
    is still up.
    
    This change removes the node from the connected nodes list before
    triggering sampling (ie sniffing).  While the fix is simple, testing was
    not because there were no existing tests for sniffing. This change also
    modifies the mocks used by transport client unit tests in order to allow
    mocking sniffing.
    rjernst committed Nov 22, 2016
    Configuration menu
    Copy the full SHA
    8a69709 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2016

  1. Configuration menu
    Copy the full SHA
    77cc348 View commit details
    Browse the repository at this point in the history