Cluster allocation explain to never return empty response body #23054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javanna
commented
Feb 8, 2017
| throw new ElasticsearchParseException("'index', 'shard', and 'primary' must be specified in allocation explain request", e); | ||
| } | ||
| return req; | ||
| return PARSER.parse(parser, new ClusterAllocationExplainRequest(), null); |
There was a problem hiding this comment.
I don't know why we were validating the request manually here. Validation is part of the transport action execution. Removing it doesn't cause any test failure.
There was a problem hiding this comment.
I don't believe its necessary, ++ for taking it out
abeyad
approved these changes
Feb 8, 2017
| throw new ElasticsearchParseException("'index', 'shard', and 'primary' must be specified in allocation explain request", e); | ||
| } | ||
| return req; | ||
| return PARSER.parse(parser, new ClusterAllocationExplainRequest(), null); |
There was a problem hiding this comment.
I don't believe its necessary, ++ for taking it out
|
retest this please |
Empty response bodies should only be sent for HEAD requests, otherwise we should always send back info about the exception that was thrown. Removed some manual exception handling in the REST action that should be rather bubbled up and handled by our rest action infra like every other rest action does.
javanna
force-pushed
the
enhancement/cluster_allocation_explain_empty_body
branch
from
d907f16
to
da2fcb8
Compare
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Feb 9, 2017
…ic#23054) Empty response bodies should only be sent for HEAD requests, otherwise we should always send back info about the exception that was thrown. Removed some manual exception handling in the REST action that should be rather bubbled up and handled by our rest action infra like every other rest action does.
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Feb 9, 2017
…ic#23054) Empty response bodies should only be sent for HEAD requests, otherwise we should always send back info about the exception that was thrown. Removed some manual exception handling in the REST action that should be rather bubbled up and handled by our rest action infra like every other rest action does.
javanna
added a commit
that referenced
this pull request
Feb 9, 2017
Empty response bodies should only be sent for HEAD requests, otherwise we should always send back info about the exception that was thrown. Removed some manual exception handling in the REST action that should be rather bubbled up and handled by our rest action infra like every other rest action does.
javanna
added a commit
that referenced
this pull request
Feb 9, 2017
Empty response bodies should only be sent for HEAD requests, otherwise we should always send back info about the exception that was thrown. Removed some manual exception handling in the REST action that should be rather bubbled up and handled by our rest action infra like every other rest action does.
javanna
added a commit
that referenced
this pull request
Feb 9, 2017
Empty response bodies should only be sent for HEAD requests, otherwise we should always send back info about the exception that was thrown. Removed some manual exception handling in the REST action that should be rather bubbled up and handled by our rest action infra like every other rest action does.
clintongormley
added
:Distributed Indexing/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty response bodies should only be sent back for HEAD requests, otherwise we should always send back info about the exception that was thrown. Removed some manual exception handling in the REST action that should be rather bubbled up and handled by our rest action infra like every other rest action does.