Fix similarity upgrade when "default" similarity is overridden #23163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 5.x we renamed the "default" similarity in "classic". Though in 2.x it is possible to override
the "default" similarity and to define a new type for "default":
````
PUT t
{
"settings": {
"index": {
"similarity": {
"default": {
"type": "BM25"
}
}
}
},
"mappings": {
"t": {
"properties": {
"title": {
"type": "text",
"similarity": "default"
}
}
}
}
}
````
When we upgrade this index to 5.x the similarity name for "text" is renamed to "classic" even though the "default" similarity type has been overriden.
This change fixes this upgrade bug and adds a test for it.
rjernst
approved these changes
Feb 14, 2017
| .endObject().string(); | ||
| Settings settings = Settings.builder() | ||
| .put(IndexMetaData.SETTING_VERSION_CREATED, VersionUtils.randomVersionBetween(random(), Version.V_2_0_0, Version.V_2_2_0)) | ||
| .put("index.similarity.default.type", "BM25") |
There was a problem hiding this comment.
Can you use something other than BM25 for the test, since that is the new default?
jimczi
added a commit
that referenced
this pull request
Feb 14, 2017
In 5.x we renamed the "default" similarity in "classic". Though in 2.x it is possible to override
the "default" similarity and to define a new type for "default":
````
PUT t
{
"settings": {
"index": {
"similarity": {
"default": {
"type": "BM25"
}
}
}
},
"mappings": {
"t": {
"properties": {
"title": {
"type": "text",
"similarity": "default"
}
}
}
}
}
````
When we upgrade this index to 5.x the similarity name for "text" is renamed to "classic" even though the "default" similarity type has been overriden.
This change fixes this upgrade bug and adds a test for it.
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered in elastic/elasticsearch-migration#103
In 5.x we renamed the "default" similarity to "classic". Though in 2.x it is possible to override
the "default" similarity and to define a new type for "default":
When we upgrade this index to 5.x the similarity name for "text" is renamed to "classic" even though the "default" similarity type has been overriden.
This change fixes this upgrade bug and adds a test for it.