Enable explicitly enforcing bootstrap checks #23585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a system property that enables end-users to explicitly enforce the bootstrap checks, indepdently of the binding of the transport protocol. This can be useful for single-node production systems that do not bind the transport protocol (and thus the bootstrap checks would not be enforced).
jasontedor
added
:Core/Infra/Core
bleskes
approved these changes
Mar 15, 2017
| @@ -101,13 +105,31 @@ static void check( | |||
| final List<String> errors = new ArrayList<>(); | |||
| final List<String> ignoredErrors = new ArrayList<>(); | |||
|
|
|||
| final String esEnforceBootstrapChecks = System.getProperty(ES_ENFORCE_BOOTSTRAP_CHECKS); | |||
There was a problem hiding this comment.
commenting here as this is the first line I can comment on. Nit: The java docs of enforceLimits needs to be adapted IMO
There was a problem hiding this comment.
Thanks @bleskes, I pushed a commit addressing your suggestion.
jasontedor
added a commit
that referenced
this pull request
Mar 15, 2017
This commit adds a system property that enables end-users to explicitly enforce the bootstrap checks, independently of the binding of the transport protocol. This can be useful for single-node production systems that do not bind the transport protocol (and thus the bootstrap checks would not be enforced). Relates #23585
|
Thanks @bleskes. |
This was referenced Apr 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a system property that enables end-users to explicitly enforce the bootstrap checks, indepdently of the binding of the transport protocol. This can be useful for single-node production systems that do not bind the transport protocol (and thus the bootstrap checks would not be enforced).
Closes #21864