Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix find remote when building BWC #27308

Merged
merged 1 commit into from
Nov 8, 2017

Conversation

jasontedor
Copy link
Member

We look for the remote by scanning the output of "git remote -v" but we were not actually looking at the output since standard output was not redirected anywhere. This commit fixes this issue.

We look for the remote by scanning the output of "git remote -v" but we
were not actually looking at the output since standard output was not
redirected anywhere. This commit fixes this issue.
@jasontedor jasontedor added :Delivery/Build Build or test infrastructure v6.1.0 v7.0.0 labels Nov 7, 2017
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasontedor jasontedor merged commit 798066a into elastic:master Nov 8, 2017
jasontedor added a commit that referenced this pull request Nov 8, 2017
We look for the remote by scanning the output of "git remote -v" but we
were not actually looking at the output since standard output was not
redirected anywhere. This commit fixes this issue.

Relates #27308
@jasontedor jasontedor deleted the fix-find-remote branch November 8, 2017 20:32
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team v6.1.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants