-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert translog changes introduced for CCR #31947
Conversation
We introduced these changes in elastic#26708 because for CCR. However, CCR now uses Lucene instead of translog. This commit reverts these changes so that we can minimize differences between the ccr and the master branch.
Pinging @elastic/es-distributed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for removing this now redundant code. LGTM
The PR CI failed because of:
I don't think it is related to the changes in this PR, but I thought changes were made so that this assertion wouldn't trigger? |
I've relaxed versionType and timestamp. This test failed because the primary terms were different. prvOp [Index{id='usxLh2QBIuRTcPeFc2TS', type='doc', seqNo=419, primaryTerm=2, version=1, versionType=EXTERNAL, autoGeneratedIdTimestamp=-1}], newOp [Index{id='usxLh2QBIuRTcPeFc2TS', type='doc', seqNo=419, primaryTerm=1, version=1, versionType=EXTERNAL, autoGeneratedIdTimestamp=-1}] |
@elasticmachine test this please |
Thanks @martijnvg for reviewing. |
We introduced these changes in #26708 because for CCR.
However, CCR now uses Lucene instead of translog.
This commit reverts these changes so that we can
minimize differences between the ccr and the master branch.