Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multi jar publishing #32195

Closed
wants to merge 3 commits into from
Closed

Fix multi jar publishing #32195

wants to merge 3 commits into from

Commits on Jul 19, 2018

  1. Auto add nebula plugin, keep a single publication 

    Versions of Gradle before 4.9 don't support project that depend on other
projects which have multiple jar publications, see gradle/gradle#1061.

It just so happens that we upgraded master and 6.x to 4.9 recently, but
6.3 is still on Gradle 4.5 so the multi publications will break there.

This change removes the client jar publication, since now the artifactId
is the only one that differes, and adds the nebula configuration to the
plugin so we don't rely on it's presence in the build scipt to generate
a correct pom. Without the plugin applied, the generated dependencies
would be empty.
    @alpar-t
    alpar-t committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    3249012 View commit details
    Browse the repository at this point in the history

  2. Keep method, used elsewhere

    @alpar-t
    alpar-t committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    b416c99 View commit details
    Browse the repository at this point in the history

  3. remove commented code

    @alpar-t
    alpar-t committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    25ea874 View commit details
    Browse the repository at this point in the history