Add infrastructure to upgrade settings #33536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasontedor
force-pushed
the
upgrade-settings
branch
2 times, most recently
from
924f4ea
to
50bd53e
Compare
In some cases we want to deprecate a setting, and then automatically upgrade uses of that setting to a replacement setting. This commit adds infrastructure for this so that we can upgrade settings when recovering the cluster state, as well as when such settings are dynamically applied on cluster update settings requests. This commit only focuses on cluster settings, index settings can build on this infrastructure in a follow-up.
jasontedor
force-pushed
the
upgrade-settings
branch
from
50bd53e
to
6952c0e
Compare
jasontedor
changed the title
jasontedor
added
review
:Core/Infra/Settings
|
Pinging @elastic/es-core-infra |
rjernst
reviewed
Sep 8, 2018
Sure, we can do that (I think it might make it easier for the index settings case). Yet, the approach here is consistent with how we register cluster settings update listeners hence why I ended up favoring this way. |
|
@rjernst I pushed a change to a plugin architecture. Would you take a look? |
jasontedor
force-pushed
the
upgrade-settings
branch
from
b91e466
to
279bad4
Compare
* master: CORE: Make Pattern Exclusion Work with Aliases (elastic#33518) Reverse logic for CCR license checks (elastic#33549) Add latch countdown on failure in CCR license tests (elastic#33548) HLRC: Add put stored script support to high-level rest client (elastic#31323) Create temporary directory if needed in CCR test Add license checks for auto-follow implementation (elastic#33496) Bootstrap a new history_uuid when force allocating a stale primary (elastic#33432) INGEST: Remove Outdated TODOs (elastic#33458) Logging: Clean up skipping test Logging: Skip test if it'd fail CRUD: AwaitsFix entire wait_for_refresh close test Painless: Add Imported Static Method (elastic#33440)
29 tasks
rjernst
reviewed
Sep 9, 2018
server/src/main/java/org/elasticsearch/common/settings/AbstractScopedSettings.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/common/settings/AbstractScopedSettings.java
Show resolved
Hide resolved
* master: Remove underscore from auto-follow API (elastic#33550) CCR: Use single global checkpoint to normalize range (elastic#33545)
|
@rjernst I responded to your feedback, would you take another look? |
jasontedor
added a commit
that referenced
this pull request
Sep 10, 2018
In some cases we want to deprecate a setting, and then automatically upgrade uses of that setting to a replacement setting. This commit adds infrastructure for this so that we can upgrade settings when recovering the cluster state, as well as when such settings are dynamically applied on cluster update settings requests. This commit only focuses on cluster settings, index settings can build on this infrastructure in a follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases we want to deprecate a setting, and then automatically upgrade uses of that setting to a replacement setting. This commit adds infrastructure for this so that we can upgrade settings when recovering the cluster state, as well as when such settings are dynamically applied on cluster update settings requests. This commit only focuses on cluster settings, index settings can build on this infrastructure in a follow-up.