Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Streamable to Writeable for WatchStatus #37390

Merged
merged 2 commits into from
Feb 15, 2019

Conversation

liketic
Copy link

@liketic liketic commented Jan 13, 2019

Migrate Streamable to Writeable for class WatchStatus.

Relates to #34389

@colings86 colings86 added the :Core/Infra/Core Core issues without another label label Jan 14, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Contributor

@jdconrad jdconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdconrad
Copy link
Contributor

@elasticmachine test this please

@jdconrad jdconrad merged commit a1531e8 into elastic:master Feb 15, 2019
@jdconrad
Copy link
Contributor

@liketic Thank you for the contribution!

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 16, 2019
* elastic/master:
  Ensure global test seed is used for all random testing tasks (elastic#38991)
  re-mutes SmokeTestWatcherWithSecurityIT (elastic#38995)
  Rollup jobs should be cleaned up before indices are deleted (elastic#38930)
  relax ML Info Docs expected response (elastic#38993)
  Re-enable single node tests (elastic#38852)
  ClusterClientIT refactor (elastic#38872)
  Fix typo in Index API doc
  Edits to text & formatting in Term Suggester doc (elastic#38963) (elastic#38989)
  Migrate Streamable to Writeable for WatchStatus (elastic#37390)
@javanna
Copy link
Member

javanna commented Feb 25, 2019

@jdconrad I added the v8.0.0 label. Can you backport this to 7.x?

@jdconrad
Copy link
Contributor

@javanna Sorry I missed this. Will back port this today.

@liketic liketic deleted the migrate-watch-status branch March 27, 2019 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants