Use a proper repository for ml-cpp artifacts #41817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This switches the strategy used to download machine learning artifacts from a manual download through S3 to using an Ivy repository on top of S3. This gives us all the benefits of Gradle dependency resolution including local caching.
jasontedor
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-core-infra |
jasontedor
added a commit
that referenced
this pull request
May 4, 2019
This switches the strategy used to download machine learning artifacts from a manual download through S3 to using an Ivy repository on top of S3. This gives us all the benefits of Gradle dependency resolution including local caching.
jasontedor
added a commit
that referenced
this pull request
May 4, 2019
This switches the strategy used to download machine learning artifacts from a manual download through S3 to using an Ivy repository on top of S3. This gives us all the benefits of Gradle dependency resolution including local caching.
jasontedor
added a commit
that referenced
this pull request
May 4, 2019
This switches the strategy used to download machine learning artifacts from a manual download through S3 to using an Ivy repository on top of S3. This gives us all the benefits of Gradle dependency resolution including local caching.
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
This switches the strategy used to download machine learning artifacts from a manual download through S3 to using an Ivy repository on top of S3. This gives us all the benefits of Gradle dependency resolution including local caching.
alpar-t
added a commit
to alpar-t/elasticsearch
that referenced
this pull request
Jun 28, 2019
This reverts commit 12bb311. Ivy considers the version to be `8.0.0-SNAPSHOT`. Since this never changes the artifact is cached indefinetly and never upgraded.
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Jun 28, 2019
Since elastic#41817 was merged the ml-cpp zip file for any given version has been cached indefinitely by Gradle. This is problematic, particularly in the case of the master branch where the version 8.0.0-SNAPSHOT will be in use for more than a year. This change tells Gradle that the ml-cpp zip file is a "changing" dependency, and to check whether it has changed every two hours. Two hours is a compromise between checking on every build and annoying developers with slow internet connections and checking rarely causing bug fixes in the ml-cpp code to take a long time to propagate through to elasticsearch PRs that rely on them.
pull bot
pushed a commit
to Mattlk13/elasticsearch
that referenced
this pull request
Jun 28, 2019
Since elastic#41817 was merged the ml-cpp zip file for any given version has been cached indefinitely by Gradle. This is problematic, particularly in the case of the master branch where the version 8.0.0-SNAPSHOT will be in use for more than a year. This change tells Gradle that the ml-cpp zip file is a "changing" dependency, and to check whether it has changed every two hours. Two hours is a compromise between checking on every build and annoying developers with slow internet connections and checking rarely causing bug fixes in the ml-cpp code to take a long time to propagate through to elasticsearch PRs that rely on them.
droberts195
added a commit
that referenced
this pull request
Jun 28, 2019
Since #41817 was merged the ml-cpp zip file for any given version has been cached indefinitely by Gradle. This is problematic, particularly in the case of the master branch where the version 8.0.0-SNAPSHOT will be in use for more than a year. This change tells Gradle that the ml-cpp zip file is a "changing" dependency, and to check whether it has changed every two hours. Two hours is a compromise between checking on every build and annoying developers with slow internet connections and checking rarely causing bug fixes in the ml-cpp code to take a long time to propagate through to elasticsearch PRs that rely on them.
droberts195
added a commit
that referenced
this pull request
Jun 28, 2019
Since #41817 was merged the ml-cpp zip file for any given version has been cached indefinitely by Gradle. This is problematic, particularly in the case of the master branch where the version 8.0.0-SNAPSHOT will be in use for more than a year. This change tells Gradle that the ml-cpp zip file is a "changing" dependency, and to check whether it has changed every two hours. Two hours is a compromise between checking on every build and annoying developers with slow internet connections and checking rarely causing bug fixes in the ml-cpp code to take a long time to propagate through to elasticsearch PRs that rely on them.
droberts195
added a commit
that referenced
this pull request
Jun 28, 2019
Since #41817 was merged the ml-cpp zip file for any given version has been cached indefinitely by Gradle. This is problematic, particularly in the case of the master branch where the version 8.0.0-SNAPSHOT will be in use for more than a year. This change tells Gradle that the ml-cpp zip file is a "changing" dependency, and to check whether it has changed every two hours. Two hours is a compromise between checking on every build and annoying developers with slow internet connections and checking rarely causing bug fixes in the ml-cpp code to take a long time to propagate through to elasticsearch PRs that rely on them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the strategy used to download machine learning artifacts from a manual download through S3 to using an Ivy repository on top of S3. This gives us all the benefits of Gradle dependency resolution including local caching.