[ML][TEST] Fix limits in AutodetectMemoryLimitIT #42279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-enable muted tests and accommodate recent backend changes that result in higher memory usage being reported for a job at the start of its life-cycle Fixes elastic#42207
|
Pinging @elastic/ml-core |
…ix/autodetect_memory_limits
droberts195
reviewed
May 21, 2019
| @@ -125,12 +124,11 @@ public void testTooManyByFields() throws Exception { | |||
| // Assert we haven't violated the limit too much | |||
| GetJobsStatsAction.Response.JobStats jobStats = getJobStats(job.getId()).get(0); | |||
| ModelSizeStats modelSizeStats = jobStats.getModelSizeStats(); | |||
| assertThat(modelSizeStats.getModelBytes(), lessThan(31500000L)); | |||
| assertThat(modelSizeStats.getModelBytes(), lessThan(33000000L)); | |||
There was a problem hiding this comment.
I would make it 35000000L to allow room for platform variations.
| @@ -175,12 +173,11 @@ public void testTooManyByAndOverFields() throws Exception { | |||
| // Assert we haven't violated the limit too much | |||
| GetJobsStatsAction.Response.JobStats jobStats = getJobStats(job.getId()).get(0); | |||
| ModelSizeStats modelSizeStats = jobStats.getModelSizeStats(); | |||
| assertThat(modelSizeStats.getModelBytes(), lessThan(31500000L)); | |||
| assertThat(modelSizeStats.getModelBytes(), lessThan(31800000L)); | |||
There was a problem hiding this comment.
Maybe 33000000L in case Mac or Windows uses more.
| @@ -226,7 +223,7 @@ public void testManyDistinctOverFields() throws Exception { | |||
| // Assert we haven't violated the limit too much | |||
| GetJobsStatsAction.Response.JobStats jobStats = getJobStats(job.getId()).get(0); | |||
| ModelSizeStats modelSizeStats = jobStats.getModelSizeStats(); | |||
| assertThat(modelSizeStats.getModelBytes(), lessThan(116000000L)); | |||
| assertThat(modelSizeStats.getModelBytes(), lessThan(116100000L)); | |||
There was a problem hiding this comment.
How about 117000000L to allow a bit more wiggle room?
Increasing the high memory limit even further to avoid disappointment with CI builds on other platforms, future changes etc.
…ix/autodetect_memory_limits
|
Jenkins run elasticsearch-ci/packaging-sample |
|
Jenkins run elasticsearch-ci/1 |
…ix/autodetect_memory_limits
|
Jenkins run elasticsearch-ci/2 |
…ix/autodetect_memory_limits
…ix/autodetect_memory_limits
edsavage
added a commit
that referenced
this pull request
May 21, 2019
Re-enable muted tests and accommodate recent backend changes that result in higher memory usage being reported for a job at the start of its life-cycle
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
May 21, 2019
* master: (176 commits) Avoid unnecessary persistence of retention leases (elastic#42299) [ML][TEST] Fix limits in AutodetectMemoryLimitIT (elastic#42279) [ML Data Frame] Persist and restore checkpoint and position (elastic#41942) mute failing filerealm hash caching tests (elastic#42304) Safer Wait for Snapshot Success in ClusterPrivilegeTests (elastic#40943) Remove 7.0.2 (elastic#42282) Revert "Remove 7.0.2 (elastic#42282)" [DOCS] Copied note on slicing support to Slicing section. Closes 26114 (elastic#40426) Remove 7.0.2 (elastic#42282) Mute all ml_datafeed_crud rolling upgrade tests Move the FIPS configuration back to the build plugin (elastic#41989) Remove stray back tick that's messing up table format (elastic#41705) Add missing comma in code section (elastic#41678) add 7.1.1 and 6.8.1 versions (elastic#42253) Use spearate testkit dir for each run (elastic#42013) Add experimental and warnings to vector functions (elastic#42205) Fix version in tests since elastic#41906 was merged Bump version in BWC check after backport Prevent in-place downgrades and invalid upgrades (elastic#41731) Mute date_histo interval bwc test ...
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
May 22, 2019
* master: (82 commits) Fix off-by-one error in an index shard test Cleanup Redundant BlobStoreFormat Class (elastic#42195) remove backcompat handling of 6.2.x versions (elastic#42044) Mute testDelayedOperationsBeforeAndAfterRelocated Execute actions under permit in primary mode only (elastic#42241) Mute another transforms_stats yaml test Deprecate support for chained multi-fields. (elastic#41926) Mute transforms_stats yaml test Make unwrapCorrupt Check Suppressed Ex. (elastic#41889) Remove Dead Code from Azure Repo Plugin (elastic#42178) Reorganize Painless doc structure (elastic#42303) Avoid unnecessary persistence of retention leases (elastic#42299) [ML][TEST] Fix limits in AutodetectMemoryLimitIT (elastic#42279) [ML Data Frame] Persist and restore checkpoint and position (elastic#41942) mute failing filerealm hash caching tests (elastic#42304) Safer Wait for Snapshot Success in ClusterPrivilegeTests (elastic#40943) Remove 7.0.2 (elastic#42282) Revert "Remove 7.0.2 (elastic#42282)" [DOCS] Copied note on slicing support to Slicing section. Closes 26114 (elastic#40426) Remove 7.0.2 (elastic#42282) ...
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
Re-enable muted tests and accommodate recent backend changes that result in higher memory usage being reported for a job at the start of its life-cycle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enable muted tests and accommodate recent backend changes
that result in higher memory usage being reported for a job
at the start of its life-cycle
Relates elastic/ml-cpp#486
Fixes #42207