Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL: handle double quotes escaping #43829

Merged
merged 7 commits into from
Jul 10, 2019
Merged

SQL: handle double quotes escaping #43829

merged 7 commits into from
Jul 10, 2019

Conversation

astefan
Copy link
Contributor

@astefan astefan commented Jul 1, 2019

Double quotes should be escaped by using another double quote. This PR adds this escaping which, previously, didn't work as expected.

Fixes #43810.

@astefan astefan added >bug :Analytics/SQL SQL querying labels Jul 1, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@astefan
Copy link
Contributor Author

astefan commented Jul 2, 2019

@elasticmachine run elasticsearch-ci/1

@astefan astefan requested review from costin and matriv July 2, 2019 06:16
@astefan
Copy link
Contributor Author

astefan commented Jul 2, 2019

@elasticmachine run elasticsearch-ci/1

Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Yet another nice catch.

Imho I would remove integration tests for this bug fix and have a unit test, using the analyzer or planner.

@astefan astefan added v7.2.2 and removed v7.2.1 labels Jul 10, 2019
@astefan astefan merged commit d589dca into elastic:master Jul 10, 2019
@astefan astefan deleted the 43810_fix branch July 10, 2019 13:03
astefan added a commit that referenced this pull request Jul 10, 2019
astefan added a commit that referenced this pull request Jul 10, 2019
astefan added a commit that referenced this pull request Jul 10, 2019
@jpountz jpountz added v7.3.0 and removed v7.3.1 labels Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQL: cannot escape double quote inside another double-quoted literal
5 participants