Geo: add validator that only checks altitude #43893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, we don't check ranges while indexing geo_shapes. As a result, it is possible to index geoshapes that contain contains coordinates outside of -90 +90 and -180 +180 ranges. Such geoshapes will break SQL and ML retrieval mechanism. This commit removes these restriction from the validator used in SQL and ML retrieval.
imotov
added
>bug
:Analytics/Geo
|
Pinging @elastic/es-analytics-geo |
talevy
reviewed
Jul 2, 2019
There was a problem hiding this comment.
small nit in the javadoc, mostly LGTM
I have one question, which might be unrelated to this PR, but more of a general
testing consideration for GeometryVisitors. It feels like we should be testing
all calls to visit for each of the different shapes. is this being done somewhere
that I am not aware of?
libs/geo/src/main/java/org/elasticsearch/geo/utils/StandardValidator.java
Outdated
Show resolved
Hide resolved
|
@elasticmachine test this please |
imotov
added a commit
that referenced
this pull request
Jul 10, 2019
By default, we don't check ranges while indexing geo_shapes. As a result, it is possible to index geoshapes that contain contain coordinates outside of -90 +90 and -180 +180 ranges. Such geoshapes will currently break SQL and ML retrieval mechanism. This commit removes these restriction from the validator is used in SQL and ML retrieval.
56 tasks
39 tasks
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Nov 15, 2019
Relates: elastic/elasticsearch#43893 This commit removes the bound checks on latitude and longitude on GeoLocation (and the derived GeoCoordinate), to allow values outside of the -90 to 90, and -180 to 180 ranges, respecitvely.
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Nov 15, 2019
Relates: elastic/elasticsearch#43893 This commit removes the bound checks on latitude and longitude on GeoLocation (and the derived GeoCoordinate), to allow values outside of the -90 to 90, and -180 to 180 ranges, respecitvely.
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Nov 15, 2019
Relates: elastic/elasticsearch#43893 This commit removes the bound checks on latitude and longitude on GeoLocation (and the derived GeoCoordinate), to allow values outside of the -90 to 90, and -180 to 180 ranges, respecitvely. (cherry picked from commit 29d68b2)
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Nov 15, 2019
Relates: elastic/elasticsearch#43893 This commit removes the bound checks on latitude and longitude on GeoLocation (and the derived GeoCoordinate), to allow values outside of the -90 to 90, and -180 to 180 ranges, respecitvely. (cherry picked from commit 29d68b2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, we don't check ranges while indexing geo_shapes. As a
result, it is possible to index geoshapes that contain contain
coordinates outside of -90 +90 and -180 +180 ranges. Such geoshapes
will currently break SQL and ML retrieval mechanism. This commit removes
these restriction from the validator is used in SQL and ML retrieval.