Deprecate the ability to update datafeed's job_id. #44691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przemekwitek
force-pushed
the
deprecate_updating_job_id
branch
from
b382970
to
4b1cd9a
Compare
|
Pinging @elastic/ml-core |
davidkyle
reviewed
Jul 22, 2019
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/datafeed/DatafeedUpdate.java
Outdated
Show resolved
Hide resolved
...high-level/src/test/java/org/elasticsearch/client/documentation/MlClientDocumentationIT.java
Outdated
Show resolved
Hide resolved
benwtrent
reviewed
Jul 22, 2019
...high-level/src/test/java/org/elasticsearch/client/documentation/MlClientDocumentationIT.java
Outdated
Show resolved
Hide resolved
|
Please also add a note to |
Done by lcawl@. Thanks! |
przemekwitek
force-pushed
the
deprecate_updating_job_id
branch
from
fe697b7
to
236ad9c
Compare
przemekwitek
force-pushed
the
deprecate_updating_job_id
branch
from
236ad9c
to
66c7af1
Compare
przemekwitek
added a commit
to przemekwitek/elasticsearch
that referenced
this pull request
Jul 23, 2019
przemekwitek
added a commit
that referenced
this pull request
Jul 23, 2019
|
@przemekwitek I think that |
|
56 tasks
Mpdreamz
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Oct 14, 2019
russcam
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Oct 21, 2019
Relates: elastic/elasticsearch#44691 * Deprecate the ability to update datafeed's job_id * remove deprecated usage of job id in update data_feed tests
russcam
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Oct 21, 2019
Relates: elastic/elasticsearch#44691 * Deprecate the ability to update datafeed's job_id * remove deprecated usage of job id in update data_feed tests (cherry picked from commit 785e275)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates the ability to specify job_id in the update datafeed endpoint.
Closes #44615