Force Merge should reject requests with only_expunge_deletes and max_num_segments set
#44761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
>bug
>breaking
:Distributed/Engine
|
@elasticmachine update branch |
|
@elasticmachine run elasticsearch-ci/packaging-sample |
dnhatn
approved these changes
Jul 24, 2019
| @@ -0,0 +1,11 @@ | |||
| [float] | |||
| [[breaking_80_indices_changes]] | |||
| === Force Merge API changes | |||
|
Thanks @dnhatn ! |
jkakavas
pushed a commit
that referenced
this pull request
Jul 31, 2019
…ax_num_segments` set (#44761) This commit changes the ForceMergeRequest.validate() method so that it does not accept the parameters only_expunge_deletes and max_num_segments to be set at the same time. The motivation is that InternalEngine.forceMerge() just ignores the max. number of segments parameter when the only expunge parameter is set to true, leaving the wrong impression to the user that max. number of segments has been applied. It also changes InternalEngine.forceMerge() so that it now throws an exception when both parameters are set, and modifies tests where needed. Because it changes the behavior of the REST API I marked this as >breaking. Closes #43102
tlrx
added a commit
that referenced
this pull request
Aug 6, 2019
This commit adds a deprecation warning in 7.x for the Force Merge API when both only_expunge_deletes and max_num_segments are set in a request. Relates #44761
jrodewig
added a commit
that referenced
this pull request
Sep 21, 2021
You can't specify `max_num_segments` and `max_num_segments` in the same request. Relates to PR #44761.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the
ForceMergeRequest.validate()method so that it does not accept the parametersonly_expunge_deletesandmax_num_segmentsto be set at the same time.The motivation is that
InternalEngine.forceMerge()just ignores the max. number of segments parameter when the only expunge parameter is set to true, leaving the wrong impression to the user that max. number of segments has been applied. This PR also changesInternalEngine.forceMerge()so that it now throws an exception when both parameters are set, and modifies tests where needed.Because it changes the behavior of the REST API I marked this as
>breaking. Once this is merged I'll open a follow up PR to add deprecation logging in 7.x.Closes #43102