Fix a bug where mappings are dropped from rollover requests. #45411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We accidentally introduced this bug when adding a typeless version of the rollover request. The bug is not present if include_type_name is set to true.
jtibshirani
added
>bug
:Search Foundations/Mapping
|
Pinging @elastic/es-core-features |
|
Pinging @elastic/es-search |
dakrone
approved these changes
Aug 9, 2019
|
Thanks @dakrone for the review ! |
jtibshirani
added a commit
that referenced
this pull request
Aug 12, 2019
We accidentally introduced this bug when adding a typeless version of the rollover request. The bug is not present if include_type_name is set to true.
jtibshirani
added a commit
that referenced
this pull request
Aug 12, 2019
We accidentally introduced this bug when adding a typeless version of the rollover request. The bug is not present if include_type_name is set to true.
jtibshirani
added a commit
that referenced
this pull request
Aug 12, 2019
We accidentally introduced this bug when adding a typeless version of the rollover request. The bug is not present if include_type_name is set to true.
colings86
removed
the
:Search Foundations/Mapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We accidentally introduced this bug when adding a typeless version of the
rollover request. The bug is not present if
include_type_nameis set to true.Addresses #45399.