Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop Executing SLM Policy Transport Action on Snapshot Pool #45727

Conversation

original-brownbear
Copy link
Member

* Executing SLM policies on the snapshot thread will block until a snapshot finishes if the pool is completely busy executing that snapshot
* Fixes elastic#45594
@original-brownbear original-brownbear added >bug :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v8.0.0 v7.4.0 labels Aug 20, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Armin

@original-brownbear
Copy link
Member Author

np + thanks for reviewing @dakrone :)

@original-brownbear original-brownbear merged commit 308af48 into elastic:master Aug 20, 2019
@original-brownbear original-brownbear deleted the move-slm-execute-off-snapshot-thread branch August 20, 2019 15:43
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Aug 20, 2019
…45727)

* Executing SLM policies on the snapshot thread will block until a snapshot finishes if the pool is completely busy executing that snapshot
* Fixes elastic#45594
original-brownbear added a commit that referenced this pull request Aug 20, 2019
…45748)

* Executing SLM policies on the snapshot thread will block until a snapshot finishes if the pool is completely busy executing that snapshot
* Fixes #45594
@original-brownbear original-brownbear restored the move-slm-execute-off-snapshot-thread branch August 6, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v7.4.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Executing a SLM policy that is already taking a snapshot times out (504 error code)
4 participants