-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Reformat ASCII folding token filter docs #48143
Merged
jrodewig
merged 6 commits into
elastic:master
from
jrodewig:reformat.asciidoc-token-filter
Oct 23, 2019
Merged
[DOCS] Reformat ASCII folding token filter docs #48143
jrodewig
merged 6 commits into
elastic:master
from
jrodewig:reformat.asciidoc-token-filter
Oct 23, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrodewig
added
>docs
General docs changes
:Search Relevance/Analysis
How text is split into tokens
v8.0.0
v7.5.0
v7.6.0
v7.4.2
labels
Oct 16, 2019
Pinging @elastic/es-docs (>docs) |
Pinging @elastic/es-search (:Search/Analysis) |
82 tasks
debadair
approved these changes
Oct 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some editorial comments, but otherwise LGTM. I think the overall format works well.
docs/reference/analysis/tokenfilters/asciifolding-tokenfilter.asciidoc
Outdated
Show resolved
Hide resolved
Thanks @debadair. |
jrodewig
added a commit
that referenced
this pull request
Oct 23, 2019
jrodewig
added a commit
that referenced
this pull request
Oct 23, 2019
jrodewig
added a commit
that referenced
this pull request
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>docs
General docs changes
:Search Relevance/Analysis
How text is split into tokens
v7.4.2
v7.5.0
v7.6.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reformats the ASCII folding token filter docs:
The
configurable parameters
andcustomize
sections build on the template in the existing simple analyzer and apostrophe token filter docs.I hope to re-use this format for other token filter docs. All feedback is welcome!