Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Reformat ASCII folding token filter docs #48143

Merged
merged 6 commits into from
Oct 23, 2019
Merged

[DOCS] Reformat ASCII folding token filter docs #48143

merged 6 commits into from
Oct 23, 2019

Conversation

jrodewig
Copy link
Contributor

Reformats the ASCII folding token filter docs:

  • Adds a title abbreviation
  • Updates the description with a short example and Lucene link
  • Adds an analyze API example with resulting tokens
  • Updates the example adding the token filter to an analyzer
  • Updates the parameter docs and custom token filter example
  • Updates the Lucene link in the apostrophe token filter docs

The configurable parameters and customize sections build on the template in the existing simple analyzer and apostrophe token filter docs.

I hope to re-use this format for other token filter docs. All feedback is welcome!

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Analysis)

Copy link
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some editorial comments, but otherwise LGTM. I think the overall format works well.

@jrodewig
Copy link
Contributor Author

Thanks @debadair.

@jrodewig jrodewig merged commit 31fc615 into elastic:master Oct 23, 2019
@jrodewig jrodewig deleted the reformat.asciidoc-token-filter branch October 23, 2019 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants