Warn when MaxDirectMemorySize or Netty Allocator Type may be incorrect (Windows/JDK8 only issue) #48546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue) (elastic#48365) Our JVM ergonomics extract max heap size from JDK PrintFlagsFinal output. On JDK 8, there is a system-dependent bug where memory sizes are cast to 32-bit integers. On affected systems (namely, Windows), when 1/4 of physical memory is more than the maximum integer value, the output of PrintFlagsFinal will be inaccurate. In the pathological case, where the max heap size would be a multiple of 4g, the test will fail. The practical effect of this bug, beyond test failures, is that we may set MaxDirectMemorySize to an incorrect value on Windows. This commit adds a warning about this situation during startup.
|
see #48550 |
| @@ -58,6 +60,11 @@ private JvmErgonomics() { | |||
| final long heapSize = extractHeapSize(finalJvmOptions); | |||
| final Map<String, String> systemProperties = extractSystemProperties(userDefinedJvmOptions); | |||
| if (systemProperties.containsKey("io.netty.allocator.type") == false) { | |||
| if (System.getProperty("os.name").startsWith("Windows") && JavaVersion.majorVersion(JavaVersion.CURRENT) == 8) { | |||
There was a problem hiding this comment.
As indicated by Yannick this has been backported in #48550 so I think your backport will turn into a backport that is identical to the original one?
|
I'm going to close this PR and reissue with another small fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to backport #48365. However, there's one additional change. Since #48310 is not being backported to 7.5, we need to warn about a potentially incorrect
io.netty.allocator.typeas well.