Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix syntax error #48554

Merged
merged 1 commit into from
Oct 29, 2019
Merged

fix syntax error #48554

merged 1 commit into from
Oct 29, 2019

Conversation

iliguanghui
Copy link
Contributor

In order to index a document with id 2, the "&" should be replaced by "?"

In order to index a document with id 2, the "&" should be replaced by "?"
Copy link

@idjevm idjevm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cbuescher cbuescher added :Search Foundations/Mapping Index mappings, including merging and defining field types >docs General docs changes v7.4.2 v7.5.0 v7.6.0 v8.0.0 labels Oct 29, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Mapping)

Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely spotted, this was easy to miss. We run our doc snippets in test but usually don't check all the results. This is clearly a mistake. Thanks.

@cbuescher
Copy link
Member

@elasticmachine test this please

@cbuescher cbuescher merged commit f06af64 into elastic:7.4 Oct 29, 2019
cbuescher pushed a commit that referenced this pull request Oct 29, 2019
In order to index a document with id 2, the "&" should be replaced by "?"
cbuescher pushed a commit that referenced this pull request Oct 29, 2019
In order to index a document with id 2, the "&" should be replaced by "?"
cbuescher pushed a commit that referenced this pull request Oct 29, 2019
In order to index a document with id 2, the "&" should be replaced by "?"
cbuescher pushed a commit that referenced this pull request Oct 29, 2019
In order to index a document with id 2, the "&" should be replaced by "?"
cbuescher pushed a commit that referenced this pull request Oct 29, 2019
In order to index a document with id 2, the "&" should be replaced by "?"
cbuescher pushed a commit that referenced this pull request Oct 29, 2019
In order to index a document with id 2, the "&" should be replaced by "?"
cbuescher pushed a commit that referenced this pull request Oct 29, 2019
In order to index a document with id 2, the "&" should be replaced by "?"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants