Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add templating support to enrich processor #49093

Merged
merged 3 commits into from
Nov 27, 2019

Conversation

martijnvg
Copy link
Member

Adds support for templating to field and target_field options.

Adds support for templating to `field` and `target_field` options.
@martijnvg martijnvg added >enhancement :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v8.0.0 v7.6.0 labels Nov 14, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Ingest)

@jbaiera jbaiera self-requested a review November 21, 2019 15:39
Copy link
Member

@jbaiera jbaiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left one optional nitpick

@@ -385,4 +397,8 @@ public SearchResponse mockResponse(Map<?, Map<String, ?>> documents) {
new SearchResponse.Clusters(1, 1, 0)
);
}

static TemplateScript.Factory str(String value) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can we make this a more descriptive name like stringLiteral?

@martijnvg martijnvg merged commit 4013e81 into elastic:master Nov 27, 2019
martijnvg added a commit that referenced this pull request Nov 27, 2019
Adds support for templating to `field` and `target_field` options.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >enhancement v7.6.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants