Pass prediction_field_type to C++ analytics process
#49861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (:ml) |
przemekwitek
force-pushed
the
fix_accuracy_comparison
branch
5 times, most recently
from
7d536ae
to
775ca8d
Compare
|
run elasticsearch-ci/packaging-sample-matrix |
|
run elasticsearch-ci/2 |
benwtrent
reviewed
Dec 6, 2019
...in/core/src/main/java/org/elasticsearch/xpack/core/ml/dataframe/analyses/Classification.java
Show resolved
Hide resolved
przemekwitek
force-pushed
the
fix_accuracy_comparison
branch
from
775ca8d
to
6a338fa
Compare
|
run elasticsearch-ci/packaging-sample-matrix |
benwtrent
approved these changes
Dec 9, 2019
przemekwitek
added a commit
that referenced
this pull request
Dec 9, 2019
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of the work started in elastic/ml-cpp#877.
It passes
prediction_field_typeparameter from Java down to C++ process.A few changes had to be made in order to make this possible:
getParamsmethod now accepts extracted fields types so that it can lookup the type of the dependent variable field0or1)Relates #49796