SQL: add trace logging for search responses coming from server #50530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-search (:Search/SQL) |
bpintea
reviewed
Jan 2, 2020
|
|
||
| protected static void logSearchResponse(SearchResponse response, Logger logger) { | ||
| List<Aggregation> aggs = Collections.emptyList(); | ||
| if (response.getAggregations() != null) { |
There was a problem hiding this comment.
Nit: wondering if expanding this branch over the for loop wouldn't also simplify (i.e. remove) the in-loop conditional, by allowing to always append ", " and then strip last two chars outside the loop.
But otherwise LGTM.
There was a problem hiding this comment.
Thanks. I do have a slight preference towards the current approach. I'll merge it as is.
astefan
added a commit
to astefan/elasticsearch
that referenced
this pull request
Jan 20, 2020
(cherry picked from commit 38eb485)
astefan
added a commit
that referenced
this pull request
Jan 20, 2020
astefan
added a commit
that referenced
this pull request
Jan 21, 2020
astefan
added a commit
that referenced
this pull request
Jan 21, 2020
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the logging of ES search responses by outputting several meta details, excluding the documents themselves.