-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Correct multi search API docs #52523
Conversation
* Adds an example request to the top of the page. * Relocates several parameters erroneously listed under "Request body" to the appropriate "Query parameters" section. * Updates the "Request body" section to better document the NDJSON structure of msearch requests.
Pinging @elastic/es-search (:Search/Search) |
Pinging @elastic/es-docs (>docs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up! A couple of nits, but otherwise LGTM - no need for another review.
This parameter also applies to <<indices-aliases,index aliases>> that point to a | ||
missing or closed index. | ||
|
||
`expand_wildcards`::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this reuse the common-parms
include as done for the request parameter above?
|
||
`preference`::: | ||
(Optional, string) | ||
Node or shard used to perform the search. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we specify the default value here?
`request_cache`::: | ||
(Optional, boolean) | ||
If `true`, the request cache can be used for this search. | ||
See <<shard-request-cache>>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default value?
Thanks for your review @romseygeek. |
* Adds an example request to the top of the page. * Relocates several parameters erroneously listed under "Request body" to the appropriate "Query parameters" section. * Updates the "Request body" section to better document the NDJSON structure of msearch requests.
* Adds an example request to the top of the page. * Relocates several parameters erroneously listed under "Request body" to the appropriate "Query parameters" section. * Updates the "Request body" section to better document the NDJSON structure of msearch requests.
Changes
to the appropriate "Query parameters" section.
structure of msearch requests.
Closes #52477.