[ML][Inference] adds new default_field_map field to trained models #53294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (:ml) |
benwtrent
force-pushed
the
feature/ml-inference-fix-field-type-mapping-confusion
branch
from
a8ecd59
to
6edfe4b
Compare
davidkyle
approved these changes
Mar 9, 2020
| @@ -226,6 +235,9 @@ public XContentBuilder toXContent(XContentBuilder builder, Params params) throws | |||
| if (licenseLevel != null) { | |||
| builder.field(LICENSE_LEVEL.getPreferredName(), licenseLevel); | |||
| } | |||
| if (defaultFieldMappings != null) { | |||
There was a problem hiding this comment.
Suggested change
| if (defaultFieldMappings != null) { | |
| if (defaultFieldMappings != null && defaultFieldMappings.isEmpty() == false) { |
I prefer not to write empty collections.
| randomBoolean() ? null : | ||
| Stream.generate(() -> randomAlphaOfLength(10)) | ||
| .limit(randomIntBetween(1, 10)) | ||
| .collect(Collectors.toMap(Function.identity(), (k) -> randomAlphaOfLength(10)))); |
There was a problem hiding this comment.
👍 neat I never thought of building a random map this way
docs/reference/ml/ml-shared.asciidoc
Outdated
| `default_field_mappings` ::: | ||
| (object) | ||
| A string to string mapping that contains the default field mappings to use | ||
| when inferring against the model. Any field mapping described in the |
There was a problem hiding this comment.
Should we add a line here about multi fields which is the primary reason for this change?
|
@elasticmachine update branch |
benwtrent
changed the title
benwtrent
deleted the
feature/ml-inference-fix-field-type-mapping-confusion
branch
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Mar 11, 2020
…lastic#53294) Adds a new `default_field_map` field to trained model config objects. This allows the model creator to supply field map if it knows that there should be some map for inference to work directly against the training data. The use case internally is having analytics jobs supply a field mapping for multi-field fields. This allows us to use the model "out of the box" on data where we trained on `foo.keyword` but the `_source` only references `foo`.
benwtrent
added a commit
that referenced
this pull request
Mar 11, 2020
…53294) (#53419) Adds a new `default_field_map` field to trained model config objects. This allows the model creator to supply field map if it knows that there should be some map for inference to work directly against the training data. The use case internally is having analytics jobs supply a field mapping for multi-field fields. This allows us to use the model "out of the box" on data where we trained on `foo.keyword` but the `_source` only references `foo`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
default_field_mapfield to trained model config objects.This allows the model creator to supply field map if it knows that there should be some map for inference to work directly against the training data.
The use case internally is having analytics jobs supply a field mapping for multi-field fields. This allows us to use the model "out of the box" on data where we trained on
foo.keywordbut the_sourceonly referencesfoo.