Make classification evaluation metrics work when there is field mapping type mismatch #53458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przemekwitek
force-pushed
the
fix_overall_accuracy
branch
2 times, most recently
from
b75cbbe
to
b05927c
Compare
przemekwitek
changed the title
|
Pinging @elastic/ml-core (:ml) |
przemekwitek
force-pushed
the
fix_overall_accuracy
branch
from
b05927c
to
8e66ea3
Compare
benwtrent
approved these changes
Mar 16, 2020
...ava/org/elasticsearch/xpack/core/ml/dataframe/evaluation/classification/PainlessScripts.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the comparison used in evaluation metrics more lenient.
Instead of comparing raw field values, it now compares their string representations so e.g.: actual field value
"1"and predicted field value1are assumed the same.Relates #53485