-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Transform] enhance the output of preview to return full destination index details #53572
[Transform] enhance the output of preview to return full destination index details #53572
Conversation
Pinging @elastic/ml-core (:ml/Transform) |
5dd8013
to
b466fb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love this change.
One comment about a logging level, but looks good.
Tricky thing with HLRC, all versions need to be forward-compatible with minor versions in the same major.
This change should be OK as the HLRC continues to work as a whole.
...in/transform/src/main/java/org/elasticsearch/xpack/transform/persistence/TransformIndex.java
Outdated
Show resolved
Hide resolved
…tic#53572) changes the output format of preview regarding deduced mappings and enhances it to return all the details about auto-index creation. This allows the user to customize the index creation. Using HLRC you can create a index request from the output of the response.
changes the output format of preview regarding deduced mappings and enhances it to return all the details about auto-index creation. This allows the user to customize the index creation. Using HLRC you can create a index request from the output of the response. backport #53572
Just caught up with emails and missed the CC unfortunately: We use mappings in the UI to infer field types for the preview tables. I'll come up with a fix this afternoon! |
- Fixes regression caused by elastic/elasticsearch#53572. - Adjusts the TS mappings and code to reflect the newly returned API response. - Re-enables functional tests.
- Fixes regression caused by elastic/elasticsearch#53572. - Adjusts the TS mappings and code to reflect the newly returned API response. - Re-enables functional tests.
Fixed in Kibana for |
changes the output format of preview regarding deduced mappings and enhances it to return all the details about auto-index creation. This allows the user to customize the index creation. Using HLRC you can create a index request from the output of the response. Long term this allows us to add UI support, see elastic/kibana#57059 and/or improve setting defaults.
The output of the preview itself is not affected. The UI does not use/display mappings at the moment (CC @walterra )
Breaking:
>=7.7
<-><7.7
<7.7
<->>=7.7
(mappings are parsed as empty)New format:
Please raise concerns about the naming:
generated_dest_index
.Old format: