[ML] Fix node serialization on GET df-nalytics stats without id #54808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the id of the `GetDataFrameAnalyticsStatsAction.Request` could be `null` which caused NPE on serialization as `writeString` is used (it doesn't accept null values). This commit ensures the id is never null. Closes elastic#54807
|
Pinging @elastic/ml-core (:ml) |
davidkyle
approved these changes
Apr 6, 2020
|
@davidkyle I agree with you. However, doing so now would be a breaking change of the transport client for the 7.x series. |
dimitris-athanasiou
deleted the
fix-node-serialization-on-get-df-analytics-stats-without-id
branch
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Apr 6, 2020
…lastic#54808) Previously, the id of the `GetDataFrameAnalyticsStatsAction.Request` could be `null` which caused NPE on serialization as `writeString` is used (it doesn't accept null values). This commit ensures the id is never null. Closes elastic#54807 Backport of elastic#54808
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the id of the
GetDataFrameAnalyticsStatsAction.Requestcould be
nullwhich caused NPE on serialization aswriteStringis used (it doesn't accept null values).
This commit ensures the id is never null.
Closes #54807