-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trimmed the main elasticsearch.yml
configuration file
#5861
Conversation
I still think I favor moving the "discovery" section to right underneath the cluster setting, as |
I agree with @dakrone that Discovery, Gateway and Cluster should be next to each other, as they all relate to cluster topology and would tend to be modified together. |
Arguably, setting the node name is even more important (since it doesn't stick after restart otherwise), and also the data/log path (since it's quite probably in a different place then it should be otherwise). The new file is 100 lines of code, and the assumption is that all settings will be reviewed for a serious deployment. With that in mind, the "Network" section can be moved before "Various" just fine. |
@karmi we discussed this today and we want to move on with what we have. I think we should push what we have (progress over perfection). Given the changes to the config related to scripting and jsonp I guess you should go over it again, can you talk a look at it again? |
Where by "what we have" we mean this trimmed configuration, or the current I'll assign the issue to myself, and will review the content against the new changes you mention next week! |
Force-pushed a commit rebased against current master. I was thinking a bit about JSONP, dynamic scripting, etc., but I don't see them as something to add into the concise configuration this pull request proposes. |
I think we should leave out the config for dynamic scripting since we have sandboxing now, enabling it should be a very advanced setting and not something people reach for at the beginning. |
elasticsearch.yml
configuration fileelasticsearch.yml
configuration file
I am pushing this out to 1.5 |
@karmi any chance you can give this a final check and get it merged? thanks |
@clintongormley @s1monw So, what can I do to have this merged? I went over the current |
@karmi How about updating links |
@lukas-vlcek Fair point, will do, thanks! |
The main `elasticsearch.yml` file mixed configuration, documentation and advice together. Due to a much improved documentation at <http://www.elastic.co/guide/>, the content has been trimmed, and only the essential settings have been left, to prevent the urge to excessive over-configuration. Related: 8d0f1a7
Rebased against master and update the URLs to point to http://elastic.co. |
this looks good to me - I will pull this in now and turn the discussion into |
Settings: Trimmed the main `elasticsearch.yml` configuration file
@s1monw Thanks!! |
elasticsearch.yml
configuration fileelasticsearch.yml
configuration file
This patch significantly trims the main
elasticsearch.yml
configuration file.The current
elasticsearch.yml
file is a relic of the past, when Elasticsearchdocumentation has been more dispersed and incomplete.
It has improved significantly, so the main configuration can be slimmed down,
and contain only the most important settings for development and production use.
Related: 8d0f1a7