Fix Expected Exception Check in BlobstoreCacheService #63474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `NodeNotConnectedException` exception can be nested as well in the fairly unlikley case of the disconnect occuring between the connected check and actually sending the request in the transport service. Closes elastic#63233
original-brownbear
added
>test
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
elasticmachine
added
the
Team:Distributed
|
Hmm not ready for review yet ... this shook out another issue https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+pull-request-2/10106/ it seems ... on it |
|
Jenkins run elasticsearch-ci/2 (failure turns out to be unrelated after all ... there's 3 failing builds with this failure before this PR was even created) -> I opened #63586 to address it. |
tlrx
approved these changes
Oct 13, 2020
|
Thanks Tanguy! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Oct 26, 2020
The `NodeNotConnectedException` exception can be nested as well in the fairly unlikley case of the disconnect occuring between the connected check and actually sending the request in the transport service. Closes elastic#63233
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Oct 26, 2020
The `NodeNotConnectedException` exception can be nested as well in the fairly unlikley case of the disconnect occuring between the connected check and actually sending the request in the transport service. Closes elastic#63233
original-brownbear
added a commit
that referenced
this pull request
Oct 26, 2020
original-brownbear
added a commit
that referenced
this pull request
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NodeNotConnectedExceptionexception can be nested as well in thefairly unlikley case of the disconnect occuring between the connected check
and actually sending the request in the transport service.
Closes #63233