Ensure Node Shutdown Waits for Running Restores to Complete #76070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We must wait for ongoing restores to complete before shutting down the repositories service. Otherwise we may leak file descriptors because tasks for releasing the store are submitted to the `SNAPSHOT` or some searchable snapshot pools that quietly accept but never reject/fail tasks after shutdown. same as elastic#46178 where we had the same bug in recoveries closes elastic#75686
original-brownbear
added
>test
|
Pinging @elastic/es-distributed (Team:Distributed) |
| @@ -2981,6 +3030,9 @@ void ensureNotClosing(final Store store) throws AlreadyClosedException { | |||
| if (store.isClosing()) { | |||
| throw new AlreadyClosedException("store is closing"); | |||
| } | |||
| if (lifecycle.started() == false) { | |||
There was a problem hiding this comment.
Added this here as well since we close the repositories service before the indices service and would otherwise have to wait for the restores to actually complete in some cases I think.
tlrx
approved these changes
Aug 4, 2021
| return; | ||
| } | ||
| final boolean added = ongoingRestores.add(shardId); | ||
| assert added; |
| @@ -2981,6 +3030,9 @@ void ensureNotClosing(final Store store) throws AlreadyClosedException { | |||
| if (store.isClosing()) { | |||
| throw new AlreadyClosedException("store is closing"); | |||
| } | |||
| if (lifecycle.started() == false) { | |||
|
Thanks Tanguy! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Aug 4, 2021
…76070) We must wait for ongoing restores to complete before shutting down the repositories service. Otherwise we may leak file descriptors because tasks for releasing the store are submitted to the `SNAPSHOT` or some searchable snapshot pools that quietly accept but never reject/fail tasks after shutdown. same as elastic#46178 where we had the same bug in recoveries closes elastic#75686
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Aug 4, 2021
…76070) We must wait for ongoing restores to complete before shutting down the repositories service. Otherwise we may leak file descriptors because tasks for releasing the store are submitted to the `SNAPSHOT` or some searchable snapshot pools that quietly accept but never reject/fail tasks after shutdown. same as elastic#46178 where we had the same bug in recoveries closes elastic#75686
original-brownbear
added a commit
that referenced
this pull request
Aug 4, 2021
…76095) We must wait for ongoing restores to complete before shutting down the repositories service. Otherwise we may leak file descriptors because tasks for releasing the store are submitted to the `SNAPSHOT` or some searchable snapshot pools that quietly accept but never reject/fail tasks after shutdown. same as #46178 where we had the same bug in recoveries closes #75686
original-brownbear
added a commit
that referenced
this pull request
Aug 4, 2021
…76092) We must wait for ongoing restores to complete before shutting down the repositories service. Otherwise we may leak file descriptors because tasks for releasing the store are submitted to the `SNAPSHOT` or some searchable snapshot pools that quietly accept but never reject/fail tasks after shutdown. same as #46178 where we had the same bug in recoveries closes #75686
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We must wait for ongoing restores to complete before shutting down the repositories
service. Otherwise we may leak file descriptors because tasks for releasing the store
are submitted to the
SNAPSHOTor some searchable snapshot pools that quietly acceptbut never reject/fail tasks after shutdown.
same as #46178 where we had the same bug in recoveries
closes #75686